CNV-32370: Rearranging setting tab #1611
Conversation
|
@metalice: This pull request references CNV-32370 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return { | ||
| canEditCpuLimits, | ||
| canEditInstancetypes, | ||
| canEditNicHotplug, | ||
| isEnabledCpuLimits, | ||
| isEnabledInstancetypes, | ||
| isEnabledNicHotplug, | ||
| loading: loadingCpuLimits || loadingInstanceTypes || loadingNicHotplug, | ||
| toggleCpuLimits, | ||
| toggleInstancetypes, | ||
| toggleNicHotplug, |
There was a problem hiding this comment.
maybe we can create an array of objects with canEdit, toggle, enabled, label, externalLink and id ? So that in the future, remove and add features will be easier?
There was a problem hiding this comment.
u have a point, i changed the hook and rendering file, now it will be easy to add features, only add 2 things to the hook for each new feature
metalice
force-pushed
the
CNV-32370-setting-layout
branch
2 times, most recently
from
c051abe
to
de83cea
Compare
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-32370-setting-layout
branch
from
de83cea
to
ce09efb
Compare
metalice
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃摑 Description
Rearranging settings tabs and adding a new tab for features.
I am adding an option to disable/enable all features together.
Edit the useFeatuers hook to be more efficient and handle loading value better.
馃帴 Demo