Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-32351: Returning node port option #1638

Merged

Conversation

metalice
Copy link
Member

馃摑 Description

Adding the option to use ssh over node port.
Rearranging the settings sections according to the design.

馃帴 Demo

image

image

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 12, 2023

@metalice: This pull request references CNV-32351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

Adding the option to use ssh over node port.
Rearranging the settings sections according to the design.

馃帴 Demo

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 12, 2023
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 12, 2023
@upalatucci
Copy link
Member

/retest

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit dd70ef3 into kubevirt-ui:main Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants