Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37629: Keep name when configuring existing SSH key in same namespace #1751

Conversation

pcbailey
Copy link
Member

馃摑 Description

When configuring an existing SSH secret for the namespace in which that secret resides in the "Manage SSH keys" section the UI displays the secret name with a randomly generated suffix. In actuality, that secret wasn't created and doesn't exist. This can be demonstrated by navigating away from that screen and returning to it. Upon doing so "Not configured" will be displayed for that namespace instead of the generated secret name.

This PR makes it so that the existing secret is used instead of generating a new name.

Jira: https://issues.redhat.com/browse/CNV-37629

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 28, 2024

@pcbailey: This pull request references CNV-37629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

When configuring an existing SSH secret for the namespace in which that secret resides in the "Manage SSH keys" section the UI displays the secret name with a randomly generated suffix. In actuality, that secret wasn't created and doesn't exist. This can be demonstrated by navigating away from that screen and returning to it. Upon doing so "Not configured" will be displayed for that namespace instead of the generated secret name.

This PR makes it so that the existing secret is used instead of generating a new name.

Jira: https://issues.redhat.com/browse/CNV-37629

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and yaacov January 28, 2024 02:21
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 28, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 28, 2024
Copy link
Contributor

openshift-ci bot commented Jan 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5b76b45 into kubevirt-ui:main Jan 28, 2024
9 checks passed
@gouyang
Copy link
Member

gouyang commented Jan 30, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1756

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants