Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41199: Remove InstanceType link from Create VM from snapshot modal #1916

Conversation

hstastna
Copy link
Member

@hstastna hstastna commented May 6, 2024

馃摑 Description

Fixes:
https://issues.redhat.com/browse/CNV-41199

Remove the unnecessary resource link from InstanceType's name displayed in Create VirtualMachine from snapshot modal.

馃帴 Screenshots

Before:
Possible to click on the resource's name and redirect to its details page:
vmci_before

After:
vmci_after

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 6, 2024

@hstastna: This pull request references CNV-41199 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

Fixes:
https://issues.redhat.com/browse/CNV-41199

Remove the unnecessary resource link from InstanceType's name displayed in Create VirtualMachine from snapshot modal.

馃帴 Screenshots

Before:
Possible to click on the resource's name and redirect to its details page:
vmci_before

After:
vmci_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan May 6, 2024 09:28
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 6, 2024
@hstastna
Copy link
Member Author

hstastna commented May 6, 2024

@avivtur @pcbailey @upalatucci @metalice please review

@@ -23,13 +23,13 @@ const InstanceTypeConfiguration: FC<InstanceTypeConfigurationProps> = ({ itMatch
</TextListItem>

<TextListItem component={TextListItemVariants.dd}>
{instanceTypeLoaded ? (
{instanceTypeLoaded && true ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it should not be here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@hstastna hstastna requested a review from upalatucci May 6, 2024 12:20
Remove the unnecessary resource link from InstanceType's name
displayed in "Create VirtualMachine from snapshot" modal.

Fixes https://issues.redhat.com/browse/CNV-41199
@hstastna hstastna force-pushed the BZ_Remove_link_from_instanceType_in_modal branch from b140c76 to 390d237 Compare May 6, 2024 12:20
@pcbailey
Copy link
Member

pcbailey commented May 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f0445c8 into kubevirt-ui:main May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants