-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-41199: Remove InstanceType link from Create VM from snapshot modal #1916
CNV-41199: Remove InstanceType link from Create VM from snapshot modal #1916
Conversation
@hstastna: This pull request references CNV-41199 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @pcbailey @upalatucci @metalice please review |
@@ -23,13 +23,13 @@ const InstanceTypeConfiguration: FC<InstanceTypeConfigurationProps> = ({ itMatch | |||
</TextListItem> | |||
|
|||
<TextListItem component={TextListItemVariants.dd}> | |||
{instanceTypeLoaded ? ( | |||
{instanceTypeLoaded && true ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it should not be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Remove the unnecessary resource link from InstanceType's name displayed in "Create VirtualMachine from snapshot" modal. Fixes https://issues.redhat.com/browse/CNV-41199
b140c76
to
390d237
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃摑 Description
Fixes:
https://issues.redhat.com/browse/CNV-41199
Remove the unnecessary resource link from InstanceType's name displayed in Create VirtualMachine from snapshot modal.
馃帴 Screenshots
Before:
Possible to click on the resource's name and redirect to its details page:
After: