CNV-40445: Display OpenshiftVirtualization Degraded warning alerts #1919
Conversation
|
@hstastna: This pull request references CNV-40445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hstastna: This pull request references CNV-40445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@avivtur @pcbailey @upalatucci @metalice please review |
|
@hstastna: This pull request references CNV-40445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
hstastna
changed the title
|
whats the difference between Link and a that make it works? |
When using "a" element, "dashboars" prefix is not added to the url. I am not sure if using "a" is correct to use here anyway. |
probably because of react router v6 append vs replace in the url |
hstastna
force-pushed
the
BZ_OpenshiftVirtualization_Degraded
branch
from
1a87c1c
to
09739e9
Compare
hstastna
changed the title
Display OpenshiftVirtualization Degraded warning alerts page correctly, when clicking on "Warning" in the Overview > Status card's related modal. Fixes https://issues.redhat.com/browse/CNV-40445
hstastna
force-pushed
the
BZ_OpenshiftVirtualization_Degraded
branch
from
09739e9
to
8145a5d
Compare
|
@avivtur @pcbailey @upalatucci @metalice please review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃摑 Description
Fixes:
https://issues.redhat.com/browse/CNV-40445
Display OpenshiftVirtualization Degraded Alerting page correctly, when clicking on Warning in Overview > Status card's related modal.
馃帴 Demo
Before:
Clicking on Warning leads to an empty page:
al_before.mp4
After:
The related page displays correctly with all the relevant alerts:
al_after.mp4