Bug 2090037: Adding template link in single VM overview details card #529
Conversation
|
@DanaOrr: This pull request references Bugzilla bug 2090037, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -115,7 +125,18 @@ const VirtualMachinesOverviewTabDetails: React.FC<VirtualMachinesOverviewTabDeta | |||
| <DescriptionListGroup> | |||
| <DescriptionListTerm>{t('Template')}</DescriptionListTerm> | |||
| <DescriptionListDescription data-test-id="virtual-machine-overview-details-template"> | |||
| {vm?.metadata?.labels?.['vm.kubevirt.io/template'] || '-'} | |||
| {templateName ? ( | |||
There was a problem hiding this comment.
| {templateName ? ( | |
| {templateName && templateNamespace ? ( |
There was a problem hiding this comment.
you should also take care of the option of name without namespace, then just show the name without a link
DanaOrr
force-pushed
the
add-template-link-in-overview
branch
from
dfab3bd
to
4964699
Compare
DanaOrr
force-pushed
the
add-template-link-in-overview
branch
from
4964699
to
f8c29be
Compare
| groupVersionKind={modelToGroupVersionKind(TemplateModel)} | ||
| name={templateName} | ||
| namespace={templateNamespace} | ||
| onClick={() => |
There was a problem hiding this comment.
why do you need to cusomize the onClick ?
| groupVersionKind={modelToGroupVersionKind(TemplateModel)} | ||
| name={templateName} | ||
| namespace={templateNamespace} | ||
| onClick={() => | ||
| history.push(`/k8s/ns/${templateNamespace}/templates/${templateName}`) | ||
| } |
There was a problem hiding this comment.
| groupVersionKind={modelToGroupVersionKind(TemplateModel)} | |
| name={templateName} | |
| namespace={templateNamespace} | |
| onClick={() => | |
| history.push(`/k8s/ns/${templateNamespace}/templates/${templateName}`) | |
| } | |
| groupVersionKind={modelToGroupVersionKind(TemplateModel)} | |
| name={templateName} | |
| namespace={templateNamespace} |
Signed-off-by: Dana Orr <dorr@redhat.com>
DanaOrr
force-pushed
the
add-template-link-in-overview
branch
from
f8c29be
to
b03cec9
Compare
Signed-off-by: Dana Orr <dorr@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DanaOrr, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@DanaOrr: All pull requests linked via external trackers have merged: Bugzilla bug 2090037 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Dana Orr dorr@redhat.com
馃摑 Description
Adding link to vm template in vm overview page.
馃帴 Demo
Before:
After:
