Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2092781: Hide the details card for non-admins #635

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Bug 2092781: Hide the details card for non-admins #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
60 changes: 32 additions & 28 deletions src/views/clusteroverview/overview/components/details-card/DetailsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';

import { useIsAdmin } from '@kubevirt-utils/hooks/useIsAdmin';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { DetailsBody } from '@openshift-console/dynamic-plugin-sdk-internal';
import { OverviewDetailItem } from '@openshift-console/plugin-shared';
Expand All @@ -11,6 +12,7 @@ import SubscriptionStatus from './SourceMissingStatus/SubscriptionStatus';

const DetailsCard: React.FC = () => {
const { t } = useKubevirtTranslation();
const isAdmin = useIsAdmin();
const kvCsvDetails = useKubevirtCSVDetails();
const {
name,
Expand All @@ -25,34 +27,36 @@ const DetailsCard: React.FC = () => {
const isLoading = !loaded && !loadError && !kubevirtSub;

return (
<Card data-test-id="kubevirt-overview-dashboard--details-card">
<CardHeader>
<CardTitle>{t('Details')}</CardTitle>
</CardHeader>
<CardBody>
<DetailsBody>
<OverviewDetailItem isLoading={isLoading} title={t('Service name')}>
{name}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Provider')}>
{provider}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('OpenShift Virtualization version')}>
{version}
<div>
{catalogSourceMissing ? (
<SourceMissingStatus />
) : (
<SubscriptionStatus subscription={kubevirtSub} />
)}
</div>
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Update Channel')}>
{updateChannel}
</OverviewDetailItem>
</DetailsBody>
</CardBody>
</Card>
isAdmin && (
<Card data-test-id="kubevirt-overview-dashboard--details-card">
<CardHeader>
<CardTitle>{t('Details')}</CardTitle>
</CardHeader>
<CardBody>
<DetailsBody>
<OverviewDetailItem isLoading={isLoading} title={t('Service name')}>
{name}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Provider')}>
{provider}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('OpenShift Virtualization version')}>
{version}
<div>
{catalogSourceMissing ? (
<SourceMissingStatus />
) : (
<SubscriptionStatus subscription={kubevirtSub} />
)}
</div>
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Update Channel')}>
{updateChannel}
</OverviewDetailItem>
</DetailsBody>
</CardBody>
</Card>
)
);
};

Expand Down