Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2097586: fix storage profile settings checkbox #652

Merged
merged 1 commit into from Jun 21, 2022

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Jun 21, 2022

馃摑 Description

The "apply StorageProfile settings" checkbox in the disk modal / edit disk modal was not working correctly,
fixed to not have accessModes and volumeMode keys when checkbox is checked, and fixing edit modal showing if user marked this checkbox before creation or not.

馃帴 Demo

before:

sp-before.mp4

after:

sp-after.mp4

Signed-off-by: Aviv Turgeman aturgema@redhat.com

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@avivtur: This pull request references Bugzilla bug 2097586, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2097586: fix storage profile settings checkbox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang June 21, 2022 12:31
@yaacov
Copy link
Member

yaacov commented Jun 21, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 21, 2022
@openshift-ci openshift-ci bot merged commit 3050f82 into kubevirt-ui:main Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2097586 has been moved to the MODIFIED state.

In response to this:

Bug 2097586: fix storage profile settings checkbox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants