Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2101667: Move VMI CPU | Memory to details section, rename Operation System #677

Merged
merged 1 commit into from Jun 28, 2022

Conversation

hstastna
Copy link
Member

@hstastna hstastna commented Jun 27, 2022

馃摑 Description

Move the CPU | Memory field from VMI Scheduling and resources requirements section to the VMI Details section in the Details tab for consistency reasons, also rename Operation System to correct "Operating system" in the same section, fix the titles for some other fields, such as Created at, Boot order, IP address, Time zone, Workload profile.

Note:
This PR fixes the VMI design as a preparation for adding Machine type field to the proper place, in the VMI Details tab,Details section.

馃帴 Demo

Before:
vmi_before
vmi_before2
After:
CPU | Memory moved to the Details section:
vmi_after
CPU | Memory not present anymore, in the Scheduling and resources requirements section:
vmi_after2

Move the CPU | Memory field from VMI Scheduling and resources
requirements section to the VMI Details section for consistency reasons,
also rename Operation system to correct Operating system in the same
section, fix the titles for some other fields, such as Created at, Boot
order, IP address, Time zone, Workload profile.
@openshift-ci openshift-ci bot requested review from pcbailey and yaacov June 27, 2022 17:40
@hstastna
Copy link
Member Author

@yaacov yaacov changed the title Move VMI CPU | Memory to details section, rename Operation System Bug 2101667: Move VMI CPU | Memory to details section, rename Operation System Jun 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

@hstastna: This pull request references Bugzilla bug 2101667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2101667: Move VMI CPU | Memory to details section, rename Operation System

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang June 28, 2022 05:37
@yaacov
Copy link
Member

yaacov commented Jun 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 28, 2022
@openshift-ci openshift-ci bot merged commit 75c2098 into kubevirt-ui:main Jun 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2101667 has been moved to the MODIFIED state.

In response to this:

Bug 2101667: Move VMI CPU | Memory to details section, rename Operation System

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants