Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2100679: Display correct number of HW devices in VM Overview #710

Conversation

hstastna
Copy link
Member

@hstastna hstastna commented Jun 30, 2022

馃摑 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2100679

Display the correct number of Hardware devices in the appropriate card in the VM Overview tab.
Additionally, fix the titles in the tab from Title Case to Uppercase, e.g. Hardware Devices to Hardware devices.
Also add the number of GPU and Host devices separately.

馃帴 Demo

Before:
device_before
After:
dev_after

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@hstastna: This pull request references Bugzilla bug 2100679, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2100679: Display correct number of HW devices in VM Overview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member Author

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@hstastna: This pull request references Bugzilla bug 2100679, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2100679: Display correct number of HW devices in VM Overview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@hstastna: This pull request references Bugzilla bug 2100679, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2100679: Display correct number of HW devices in VM Overview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna hstastna force-pushed the BZ_Number_of_hardware_devices_VM_overview branch from c2ba9f9 to 69c2007 Compare June 30, 2022 19:24
Display the correct number of Hardware devices in the appropriate card
in the VM Overview tab.
Additionally, fix the titles in the tab from Title Case to Uppercase,
e.g. Hardware Devices to Hardware devices.
Also add the number of GPU and Host devices separately.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2100679
@hstastna hstastna force-pushed the BZ_Number_of_hardware_devices_VM_overview branch from 69c2007 to 0100932 Compare June 30, 2022 19:44
@glekner
Copy link
Contributor

glekner commented Jul 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 3, 2022
@openshift-ci openshift-ci bot merged commit 9603bbb into kubevirt-ui:main Jul 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2100679 has been moved to the MODIFIED state.

In response to this:

Bug 2100679: Display correct number of HW devices in VM Overview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants