Bug 2101335: Clone action enabled for CrashLoopBackOff

[glekner]

📝 Description

Add a brief description

🎥 Demo

Please add a video or an image of the behavior/changes

[openshift-ci]

@glekner: This pull request references Bugzilla bug 2101335, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2101335: Clone action enabled for CrashLoopBackOff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[avivtur]

/lgtm

[metalice]

/lgtm

[hstastna]

Looks like the fix does not include other error-like states. What about them? There is the additional info in the BZ:

Additional info: Also reproduced with other error states like ErrImagePull or ImagePullBackOff.

Seems to me that there may be more states we should take care of. Maybe it would be good to check/include all possible error-like states. If there are too many such states, maybe it worth to fix this the opposite way: to create an array with the states that are okay for cloning and then to check if the actual state is in that array. And if not, then to disable cloning.

[upalatucci]

This will add a new filter in the VM list

I suggest to filter it here or creating a different array/object for the filters

[glekner]

@upalatucci @hstastna thanks, ill take a look

[glekner]

@avivtur @upalatucci @hstastna

please note all the possible vm statuses here

I fixed isFailedPrintableStatus and clone is now only enabled if the vm is paused to stopped

[upalatucci]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, glekner, metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avivtur,glekner,metalice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@glekner: All pull requests linked via external trackers have merged:

• kubevirt-ui/kubevirt-plugin#738

Bugzilla bug 2101335 has been moved to the MODIFIED state.

In response to this:

Bug 2101335: Clone action enabled for CrashLoopBackOff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.