Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2114516: Open website after clicking on Fedora cloud image list link #808

Merged
merged 1 commit into from Aug 3, 2022
Merged

Bug 2114516: Open website after clicking on Fedora cloud image list link #808

merged 1 commit into from Aug 3, 2022

Conversation

hstastna
Copy link
Member

@hstastna hstastna commented Aug 2, 2022 •
edited

馃摑 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2114516

Make the link in the "Example" for Fedora work, when editing template's disk and choosing "URL (creates PVC)" as Source in the Edit disk modal.

The core of the problem was missing some default value for the os (in some edge cases when it is undefined), comparing to what is returned for getURLSourceHelpertText function (used in the affected component): Fedora OS related helper text. So the same OS was used as the default one also in the affected URLSourceHelperText component.

馃帴 Demo

Before:
Nothing happens after clicking on Fedora cloud image list link.
fedora_before
After:
The corresponding website is opened:
fedora_after

@hstastna
Bug 2114516: Open website after clicking on Fedora cloud image list link
a58bb56 
Make the link in the "Example" for Fedora work, when editing template's
disk and choosing "URL (creates PVC)" as Source in the Edit disk modal.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2114516
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang August 2, 2022 22:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

5 similar comments
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@hstastna: This pull request references Bugzilla bug 2114516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member Author

hstastna commented Aug 2, 2022

@glekner @avivtur @metalice @pcbailey @yzamir @vojtechszocs please review

@metalice
Copy link
Member

metalice commented Aug 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 3, 2022
@openshift-ci openshift-ci bot merged commit a9de25c into kubevirt-ui:main Aug 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2114516 has been moved to the MODIFIED state.

In response to this:

Bug 2114516: Open website after clicking on Fedora cloud image list link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upalatucci upalatucci Awaiting requested review from upalatucci

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hstastna @metalice