Bug 2104859: Add "Copy SSH command" to VM actions #822

hstastna · 2022-08-08T16:58:13Z

📝 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2104859
https://bugzilla.redhat.com/show_bug.cgi?id=2117803

Add "Copy SSH command" option to kebab menu for the actions in the VM list, also to Actions button in the VM details view/tabs, to copy the command fast and comfortably.

Make editing SSH access field available in the VM Details tab, even when the VM is stopped.

Add missing popovers for "SSH over NodePort" and "SSH using virtctl" in the VM Details tab according to the design doc.

Design doc:
https://docs.google.com/document/d/1FyTSLtTBgl4wJn4BJO-lTeG7rGA9cq1eWlH-a5c0jHI/edit#heading=h.r9srzahlc6ei

🎥 Demo

Before:
The Actions menu before:

After:
"Copy SSH command" in the VM Overview tab:

"Copy SSH command" in the VM list view:

Popovers in the VM Details tab:

TODO:

use virtctl command for "Copy SSH command"
display the PF copy icon next to the text "Copy SSH command"
enable "Copy SSH command" for the VM that is stopped
fix failing test
add a description for "Copy SSH command": "SSH using virtctl"

openshift-ci · 2022-08-08T16:58:24Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-08-08T16:59:28Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hstastna · 2022-08-08T17:05:47Z

@glekner @avivtur @metalice @pcbailey @yzamir @vojtechszocs please review
Can you help me, folks, to find a reason of not displaying the copy icon as expected? Expected:

And the related line of the code here.

openshift-ci · 2022-08-08T17:07:16Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

avivtur

Hi @hstastna the PR looks great 😄
in order for you to show the icon you need to go to here and add the line:
icon={action?.icon}
but the PF dropdown will show the icon before the rendered child as written in their docs, I think it's ok since it's coming from PF and I wouldn't try to change that (and not sure if it is possible 😆 )
Can I also ask of you please to move this directory to here as well in this PR? it makes more sense to me to have the actions compnent under the actions directory, I know you didn't made it like this, but it will be nice that it will be changed :)
Also make sure to apply needed changes to this unit-test to make our CI happy again :)

src/views/virtualmachines/actions/hooks/useVirtualMachineActionsProvider.ts

openshift-ci · 2022-08-09T14:37:24Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-08-09T14:37:29Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-08-09T14:38:08Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hstastna · 2022-08-09T15:36:24Z

@avivtur Here's one another thing that bothers me: in the design doc for this, there's "Copy SSH command" using virtctl for the drop down item that was already implemented in the VM Overview tab. But when I check it, it does not seem to use virtctl. I'd expect to see some command like virtctl -n ... when I copy that command. Yifat thinks that the doc is correct. What am I missing? Did we miss virtctl when implementing or was there any design change I and Yifat are not aware of? Maybe @upalatucci knows more? Thanks!

openshift-ci · 2022-08-10T10:06:41Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hstastna · 2022-08-10T11:30:04Z

/retest

openshift-ci · 2022-08-10T12:04:04Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-08-25T20:07:55Z

@hstastna: This pull request references Bugzilla bug 2104859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vojtechszocs · 2022-08-25T20:08:48Z

/lgtm

vojtechszocs · 2022-08-25T20:11:07Z

/lgtm cancel

vojtechszocs · 2022-08-25T20:15:59Z

/lgtm

openshift-bot · 2022-08-25T20:24:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

vojtechszocs · 2022-08-25T20:36:53Z

/lgtm

Add "Copy SSH command" option to kebab menu for the actions in the VM list, also to Actions button in the VM details view/tabs (SSH using virtctl). Make editing SSH access field available in the VM Details tab, even when the VM is stopped. Add missing popovers for "SSH over NodePort" and "SSH using virtctl" in the VM Details tab according to the design doc. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2104859 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2117803

vojtechszocs · 2022-08-25T20:50:27Z

/lgtm

openshift-ci · 2022-08-25T20:50:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-08-25T22:16:34Z

@hstastna: All pull requests linked via external trackers have merged:

kubevirt-ui/kubevirt-plugin#822

Bugzilla bug 2104859 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hstastna · 2022-09-23T16:47:45Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-09-23T16:48:24Z

@hstastna: #822 failed to apply on top of branch "release-4.11":

Applying: Bug 2104859: Add "Copy SSH command" to VM actions
Using index info to reconstruct a base tree...
M	locales/en/plugin__kubevirt-plugin.json
A	src/utils/components/Consoles/components/DesktopViewer/Components/RDPServiceNotConfigured.tsx
A	src/utils/components/SSHAccess/components/ConsoleOverVirtctl.tsx
A	src/utils/components/SSHAccess/components/SSHCommand.tsx
A	src/utils/components/SSHAccess/useSSHCommand.ts
M	src/views/virtualmachines/actions/VirtualMachineActionFactory.tsx
M	src/views/virtualmachines/actions/hooks/useVirtualMachineActionsProvider.ts
M	src/views/virtualmachines/details/tabs/overview/components/VirtualMachinesOverviewTabDetails/components/VirtualMachinesOverviewTabDetailsTitle.tsx
M	src/views/virtualmachines/list/components/VirtualMachineActions/VirtualMachineActions.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/views/virtualmachines/details/tabs/overview/components/VirtualMachinesOverviewTabDetails/components/VirtualMachinesOverviewTabDetailsTitle.tsx
CONFLICT (content): Merge conflict in src/views/virtualmachines/details/tabs/overview/components/VirtualMachinesOverviewTabDetails/components/VirtualMachinesOverviewTabDetailsTitle.tsx
Auto-merging src/views/virtualmachines/actions/hooks/useVirtualMachineActionsProvider.ts
Auto-merging src/views/virtualmachines/actions/components/VirtualMachineActions/VirtualMachineActions.tsx
Auto-merging src/views/virtualmachines/actions/VirtualMachineActionFactory.tsx
Auto-merging src/utils/components/UserCredentials/useSSHCommand.ts
CONFLICT (modify/delete): src/utils/components/SSHAccess/components/SSHCommand.tsx deleted in HEAD and modified in Bug 2104859: Add "Copy SSH command" to VM actions. Version Bug 2104859: Add "Copy SSH command" to VM actions of src/utils/components/SSHAccess/components/SSHCommand.tsx left in tree.
CONFLICT (modify/delete): src/utils/components/SSHAccess/components/ConsoleOverVirtctl.tsx deleted in HEAD and modified in Bug 2104859: Add "Copy SSH command" to VM actions. Version Bug 2104859: Add "Copy SSH command" to VM actions of src/utils/components/SSHAccess/components/ConsoleOverVirtctl.tsx left in tree.
CONFLICT (modify/delete): src/utils/components/Consoles/components/DesktopViewer/Components/RDPServiceNotConfigured.tsx deleted in HEAD and modified in Bug 2104859: Add "Copy SSH command" to VM actions. Version Bug 2104859: Add "Copy SSH command" to VM actions of src/utils/components/Consoles/components/DesktopViewer/Components/RDPServiceNotConfigured.tsx left in tree.
Auto-merging locales/en/plugin__kubevirt-plugin.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2104859: Add "Copy SSH command" to VM actions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from tnisan and yaacov August 8, 2022 16:58

openshift-ci bot added bugzilla/severity-medium bugzilla/valid-bug labels Aug 8, 2022

openshift-ci bot requested a review from gouyang August 8, 2022 16:58

avivtur reviewed Aug 8, 2022

View reviewed changes

src/views/virtualmachines/actions/hooks/useVirtualMachineActionsProvider.ts Outdated Show resolved Hide resolved

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch from 918b655 to 59bb1b3 Compare August 9, 2022 14:28

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch 2 times, most recently from 3c7137a to 958ffa8 Compare August 9, 2022 14:55

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch 2 times, most recently from 11351f1 to d787d45 Compare August 9, 2022 16:01

hstastna requested a review from avivtur August 9, 2022 16:21

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch 4 times, most recently from 287c27d to e8ed9f0 Compare August 12, 2022 12:54

hstastna changed the title ~~Bug 2104859: Add "Copy SSH command" to VM actions~~ [WIP] Bug 2104859: Add "Copy SSH command" to VM actions Aug 12, 2022

openshift-ci bot added the do-not-merge/work-in-progress label Aug 12, 2022

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch from e8ed9f0 to 3aa48d1 Compare August 12, 2022 16:11

openshift-ci bot assigned vojtechszocs Aug 25, 2022

openshift-ci bot added lgtm Passed code review, ready for merge approved This issue is something we want to fix labels Aug 25, 2022

openshift-ci bot removed lgtm Passed code review, ready for merge approved This issue is something we want to fix labels Aug 25, 2022

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch 2 times, most recently from 0e04bb3 to cc33ddd Compare August 25, 2022 20:13

openshift-ci bot added lgtm Passed code review, ready for merge approved This issue is something we want to fix labels Aug 25, 2022

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch from cc33ddd to a826ada Compare August 25, 2022 20:33

openshift-ci bot removed the lgtm Passed code review, ready for merge label Aug 25, 2022

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch from a826ada to 63f1cc4 Compare August 25, 2022 20:36

openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 25, 2022

hstastna force-pushed the RFE_Add_Copy_SSH_command_VM_actions branch from 63f1cc4 to 90fadef Compare August 25, 2022 20:46

openshift-ci bot removed the lgtm Passed code review, ready for merge label Aug 25, 2022

openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 25, 2022

openshift-merge-robot merged commit fb88028 into kubevirt-ui:main Aug 25, 2022

hstastna mentioned this pull request Sep 23, 2022

Bug 2129235: Add "Copy SSH command" to VM actions #893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2104859: Add "Copy SSH command" to VM actions #822

Bug 2104859: Add "Copy SSH command" to VM actions #822

hstastna commented Aug 8, 2022 •

edited

openshift-ci bot commented Aug 8, 2022

openshift-ci bot commented Aug 8, 2022

hstastna commented Aug 8, 2022 •

edited

openshift-ci bot commented Aug 8, 2022

avivtur left a comment •

edited

openshift-ci bot commented Aug 9, 2022

openshift-ci bot commented Aug 9, 2022

openshift-ci bot commented Aug 9, 2022

hstastna commented Aug 9, 2022

openshift-ci bot commented Aug 10, 2022

hstastna commented Aug 10, 2022

openshift-ci bot commented Aug 10, 2022

openshift-ci bot commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

openshift-bot commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

openshift-ci bot commented Aug 25, 2022

openshift-ci bot commented Aug 25, 2022

hstastna commented Sep 23, 2022

openshift-cherrypick-robot commented Sep 23, 2022

Bug 2104859: Add "Copy SSH command" to VM actions #822

Bug 2104859: Add "Copy SSH command" to VM actions #822

Conversation

hstastna commented Aug 8, 2022 • edited

📝 Description

🎥 Demo

openshift-ci bot commented Aug 8, 2022

openshift-ci bot commented Aug 8, 2022

hstastna commented Aug 8, 2022 • edited

openshift-ci bot commented Aug 8, 2022

avivtur left a comment • edited

Choose a reason for hiding this comment

openshift-ci bot commented Aug 9, 2022

openshift-ci bot commented Aug 9, 2022

openshift-ci bot commented Aug 9, 2022

hstastna commented Aug 9, 2022

openshift-ci bot commented Aug 10, 2022

hstastna commented Aug 10, 2022

openshift-ci bot commented Aug 10, 2022

openshift-ci bot commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

openshift-bot commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

vojtechszocs commented Aug 25, 2022

openshift-ci bot commented Aug 25, 2022

openshift-ci bot commented Aug 25, 2022

hstastna commented Sep 23, 2022

openshift-cherrypick-robot commented Sep 23, 2022

hstastna commented Aug 8, 2022 •

edited

hstastna commented Aug 8, 2022 •

edited

avivtur left a comment •

edited