Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2099556: Adding the option to enable Rdp service in one click to windows vm #832

Conversation

DanaOrr
Copy link
Contributor

@DanaOrr DanaOrr commented Aug 11, 2022

Signed-off-by: Dana Orr dorr@redhat.com

馃摑 Description

In the console tab in windows vm, we can add the Rdp service on viewer desktop with one click instead of manually.

馃帴 Demo

Before:
image

After:
rdpService

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@DanaOrr: An error was encountered querying GitHub for users with public email (gouyang@redhat.com) for bug 2099556 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2099556: Adding the option to enable Rdp service in one click to windows vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DanaOrr
Copy link
Contributor Author

DanaOrr commented Aug 11, 2022

/retest

@avivtur
Copy link
Member

avivtur commented Aug 11, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@avivtur: This pull request references Bugzilla bug 2099556, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang August 11, 2022 10:24
@DanaOrr DanaOrr force-pushed the adding-option-to-enable-rdp-service branch 4 times, most recently from ef8d7ce to d0a0e03 Compare August 11, 2022 13:32
@DanaOrr DanaOrr closed this Aug 11, 2022
@DanaOrr DanaOrr force-pushed the adding-option-to-enable-rdp-service branch from d0a0e03 to 0f9f7a6 Compare August 11, 2022 13:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@DanaOrr: This pull request references Bugzilla bug 2099556. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
Warning: Failed to comment on Bugzilla bug with reason for changed state.

In response to this:

Bug 2099556: Adding the option to enable Rdp service in one click to windows vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member

@DanaOrr What is the reason of closing this PR? Thanks!

@DanaOrr DanaOrr reopened this Aug 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@DanaOrr: This pull request references Bugzilla bug 2099556, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2099556: Adding the option to enable Rdp service in one click to windows vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DanaOrr DanaOrr force-pushed the adding-option-to-enable-rdp-service branch 2 times, most recently from 8995bf7 to 6261338 Compare August 11, 2022 14:26
Signed-off-by: Dana Orr <dorr@redhat.com>
@DanaOrr DanaOrr force-pushed the adding-option-to-enable-rdp-service branch from 6261338 to c5d1e99 Compare August 11, 2022 14:30
@avivtur
Copy link
Member

avivtur commented Aug 11, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, DanaOrr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit af4e4ec into kubevirt-ui:main Aug 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@DanaOrr: All pull requests linked via external trackers have merged:

Bugzilla bug 2099556 has been moved to the MODIFIED state.

In response to this:

Bug 2099556: Adding the option to enable Rdp service in one click to windows vm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants