Bug 2128002: Display VM Templates list after template deletion #886
Conversation
|
@hstastna: This pull request references Bugzilla bug 2128002, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hstastna
force-pushed
the
BZ_Error_after_VM_template_deletion
branch
2 times, most recently
from
9041053
to
b20da75
Compare
|
@avivtur @metalice @pcbailey @yzamir @vojtechszocs please review |
| history.push(`/k8s/${lastNamespacePath}/templates`); | ||
| }) | ||
| .then(() => history.push(`/k8s/${lastNamespacePath}/templates`)) | ||
| .catch((e) => console.error(e)); |
There was a problem hiding this comment.
If you remove this, the modal will handle the error showing the message in an alert on top of submit button
There was a problem hiding this comment.
The catch block is unnecessary here, of course. But it's a good practice to use it whenever working with promises.
There was a problem hiding this comment.
Yes but the modal will not handle the expection because it's catched here. So no error message will be prompted. If you want this, you should re throw the expection in the catch function or just remove the catch
There was a problem hiding this comment.
@hstastna Can you confirm that you don't want the error message to be shown? I don't feel comfortable lgtm'ing this without resolving this conversation.
hstastna
force-pushed
the
BZ_Error_after_VM_template_deletion
branch
from
b20da75
to
609eeeb
Compare
hstastna
force-pushed
the
BZ_Error_after_VM_template_deletion
branch
from
609eeeb
to
ec98807
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2128002 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2128002
馃帴 Demo
Before:
After: