Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2119613: Fix disk size units display #914

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

pcbailey
Copy link
Member

馃摑 Description

This PR fixes a bug in the display of disk size units that was present in both the 'Edit boot source' modal and anywhere DiskSizeNumberInput was used. This bug would cause the units to change from its existing value to B if the existing value was deleted or the value was changed to zero.

馃帴 Screenshots

Before:
Selection_171

After:
Selection_170

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

@pcbailey: This pull request references Bugzilla bug 2119613, which is invalid:

  • expected the bug to target the "4.11.z" release, but it targets "4.11.1" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2119613: Fix disk size units display

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 13, 2022
@pcbailey
Copy link
Member Author

/retest

@pcbailey pcbailey force-pushed the fix-disk-size-units-4.11 branch 2 times, most recently from 5dda8ce to a3683fd Compare October 31, 2022 15:29
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pcbailey
Copy link
Member Author

/override "DeepSource: JavaScript"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

@pcbailey: Overrode contexts on behalf of pcbailey: DeepSource: JavaScript

In response to this:

/override "DeepSource: JavaScript"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey pcbailey merged commit 85565d4 into kubevirt-ui:release-4.11 Oct 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2022

@pcbailey: All pull requests linked via external trackers have merged:

Bugzilla bug 2119613 has been moved to the MODIFIED state.

In response to this:

Bug 2119613: Fix disk size units display

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants