-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2119613: Fix disk size units display #914
Bug 2119613: Fix disk size units display #914
Conversation
Signed-off-by: Dana Orr <dorr@redhat.com>
@pcbailey: This pull request references Bugzilla bug 2119613, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
5dda8ce
to
a3683fd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "DeepSource: JavaScript" |
@pcbailey: Overrode contexts on behalf of pcbailey: DeepSource: JavaScript In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pcbailey: All pull requests linked via external trackers have merged: Bugzilla bug 2119613 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
This PR fixes a bug in the display of disk size units that was present in both the 'Edit boot source' modal and anywhere
DiskSizeNumberInput
was used. This bug would cause the units to change from its existing value toB
if the existing value was deleted or the value was changed to zero.馃帴 Screenshots
Before:
After: