Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2132744: Description text is missing in Live Migrations section #918

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Oct 18, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

馃摑 Description

remove redundant description text of "some text" from overview settings tab under live migrations sub tab

馃帴 Demo

remove_description_text_overview_settings

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@avivtur: This pull request references Bugzilla bug 2132744, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2132744: Description text is missing in Live Migrations section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 18, 2022
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 18, 2022
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the remove_description_text_overview_settings branch from 50804ff to 1fd166e Compare October 18, 2022 13:39
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Oct 18, 2022
@avivtur
Copy link
Member Author

avivtur commented Oct 18, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@avivtur: This pull request references Bugzilla bug 2132744, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: lkladnit.

Note that only kubevirt-ui members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@avivtur: This pull request references Bugzilla bug 2132744, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9fe2952 into kubevirt-ui:main Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2132744 has been moved to the MODIFIED state.

In response to this:

Bug 2132744: Description text is missing in Live Migrations section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants