Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2140627: Allow to select storageClass in Add disk modal #955

Conversation

hstastna
Copy link
Member

@hstastna hstastna commented Nov 7, 2022

馃摑 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2140627

Allow to select StorageClass when adding a new Disk to a VM if there is no default storageclass defined.

Note that if you want to reproduce this bug, you need to:

  • set the annotation storageclass.kubernetes.io/is-default-class to 'false' for all storage classes
    (in Storage > StorageClasses)

馃帴 Screenshots

Before:
Not being able to select a different StorageClass than already selected (nothing happens when clicking on it):
sc_before
Error in the browser console:
sc_err
After:
Successfully selected a different StorageClass, incl. displaying the correct info:
sc_after

Allow to select StorageClass when adding a new Disk to a VM
if there is no default storageclass defined.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2140627
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@hstastna: This pull request references Bugzilla bug 2140627, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2140627: Allow to select storageClass in Add disk modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang November 7, 2022 17:07
@hstastna
Copy link
Member Author

hstastna commented Nov 7, 2022

@avivtur @metalice @pcbailey @yzamir @vojtechszocs please review

@metalice
Copy link
Member

metalice commented Nov 7, 2022

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 815da80 into kubevirt-ui:main Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2140627 has been moved to the MODIFIED state.

In response to this:

Bug 2140627: Allow to select storageClass in Add disk modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants