Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2140521: Delete a VM or template from all projects leads to 404 error #965

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Nov 14, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

📝 Description

useLastNamespace hook was failing for non-admin users but it seems to work properly again so restored the useLastNamespace hook from SDK.

NOTES:

  • should also fix: Bug 2140521
  • couldn't reproduce the bug for local dev env (localhost) but only on QE clusters via the web console.
  • tested both for VMs and for Templates, as admin and non-admin users.

🎥 Demo

Before

Delete from inside the VM

non-exist-ns.mp4

Delete from VMs list

404.mp4

After

Delete from inside the VM

all-ns-delete.mp4

Delete from VMs list

all-ns-delete-vm-list.mp4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@avivtur: This pull request references Bugzilla bug 2142470, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2142470: Delete a VM or template from all projects leads to 404 error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 14, 2022
@openshift-ci openshift-ci bot requested a review from gouyang November 14, 2022 08:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@avivtur: This pull request references Bugzilla bug 2142470, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2142470: Delete a VM or template from all projects leads to 404 error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur avivtur changed the title Bug 2142470: Delete a VM or template from all projects leads to 404 error Bug 2140521: Delete a VM or template from all projects leads to 404 error Nov 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@avivtur: This pull request references Bugzilla bug 2140521, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2140521: Delete a VM or template from all projects leads to 404 error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…rror

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the fix-use-last-namespace-path-hook branch from 875f522 to e272f14 Compare November 14, 2022 08:24
@avivtur avivtur mentioned this pull request Nov 14, 2022
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member Author

avivtur commented Nov 15, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit f8cc456 into kubevirt-ui:main Nov 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2140521 has been moved to the MODIFIED state.

In response to this:

Bug 2140521: Delete a VM or template from all projects leads to 404 error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants