-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2144580: Make Help icon small in VM Template's Disks tab #981
Bug 2144580: Make Help icon small in VM Template's Disks tab #981
Conversation
Display the Patternfly HelpIcon in size small, according to the design recommendations, in the Disks tab's page title. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2144580
@hstastna: This pull request references Bugzilla bug 2144580, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@avivtur @metalice @pcbailey @yzamir @vojtechszocs please review |
@hstastna: This pull request references Bugzilla bug 2144580, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, hstastna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2144580 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.12 |
@hstastna: new pull request created: #982 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2144580
Display the Patternfly HelpIcon in size small, according to the design recommendations and for consistency reasons, in the Disks tab's page title.
Note:
There is an older BZ for the same problem but for VMs:
https://bugzilla.redhat.com/show_bug.cgi?id=2090057
馃帴 Screenshots
Before:
After: