Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2144580: Make Help icon small in VM Template's Disks tab #981

Merged

Conversation

hstastna
Copy link
Member

@hstastna hstastna commented Nov 21, 2022

馃摑 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2144580

Display the Patternfly HelpIcon in size small, according to the design recommendations and for consistency reasons, in the Disks tab's page title.

Note:
There is an older BZ for the same problem but for VMs:
https://bugzilla.redhat.com/show_bug.cgi?id=2090057

馃帴 Screenshots

Before:
icon_before
After:
icon_after

Display the Patternfly HelpIcon in size small, according to the design
recommendations, in the Disks tab's page title.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2144580
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

@hstastna: This pull request references Bugzilla bug 2144580, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2144580: Make Help icon small in VM Template's Disks tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang November 21, 2022 19:11
@hstastna
Copy link
Member Author

@avivtur @metalice @pcbailey @yzamir @vojtechszocs please review

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

@hstastna: This pull request references Bugzilla bug 2144580, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2144580: Make Help icon small in VM Template's Disks tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit e2e5bca into kubevirt-ui:main Nov 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2144580 has been moved to the MODIFIED state.

In response to this:

Bug 2144580: Make Help icon small in VM Template's Disks tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@hstastna: new pull request created: #982

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants