Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite unit-tests with ginkgo #142

Merged
merged 2 commits into from
Sep 22, 2022
Merged

rewrite unit-tests with ginkgo #142

merged 2 commits into from
Sep 22, 2022

Conversation

sankalp-r
Copy link
Contributor

Fixes: #91

Signed-off-by: Sankalp Rangare sankalprangare786@gmail.com

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 30, 2022
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2022
@kubevirt-bot
Copy link
Contributor

Hi @sankalp-r. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gonzolino
Copy link
Contributor

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2022
@mfranczy
Copy link
Contributor

/assign @mfranczy

mfranczy
mfranczy requested changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your PR against the lastet changes.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2022
@kubevirt-bot kubevirt-bot added size/XL and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Sep 6, 2022
mfranczy
mfranczy requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sankalp-r let's avoid having complex logic in tests that based on the input differs with result. The test scenario should be simple and easy to read. We can sync on that before you make another changes.

pkg/provider/loadbalancer_test.go Outdated

})

DescribeTable("Ensure loadbalancer", func(checkSvcExistErr error, getCount int, portsChanged bool, updateSvcErr error, createSvcErr error, pollSvcErr error, expectedError error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is too complex, we should divide that into multiple scenarios instead of implementing a complex logic for DescribeTable. Let's cover this with It("Should <description of the case>").

pkg/provider/loadbalancer_test.go Outdated

})

DescribeTable("Update loadbalancer", func(getSvcErr error, updateSvcErr error, expectedError error, portsChanged bool) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my above comment, let's avoid having a complex logic for tests.

@sankalp-r
update loadbalancer test
32c9bd4 
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
mfranczy
mfranczy reviewed Sep 22, 2022
View reviewed changes
pkg/provider/loadbalancer_test.go Outdated
t.Errorf("Expected: '%v', got '%v'", test.expectedError, err)
}
}
func copyService(src *corev1.Service, dst *corev1.Service) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not DeepCopy()?

mfranczy
mfranczy requested changes Sep 22, 2022
View reviewed changes
pkg/provider/loadbalancer_test.go Outdated

for i := 0; i < getCount; i++ {
infraService2 := &corev1.Service{}
copyService(infraService1, infraService2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use infraService1.DeepCopy() instead of copyService that can be removed.

@sankalp-r
refactor test to use deepCopy
6417efe 
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
mfranczy
mfranczy approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@kubevirt-bot kubevirt-bot merged commit 26cd50c into kubevirt:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranczy mfranczy mfranczy approved these changes

@gonzolino gonzolino Awaiting requested review from gonzolino

Assignees

@mfranczy mfranczy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Ginkgo for all unit-tests
4 participants
@sankalp-r @kubevirt-bot @gonzolino @mfranczy