Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a possibility to read namespace from CCM config #88

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

hdurand0710
Copy link
Contributor

@hdurand0710 hdurand0710 commented Jul 4, 2022

This PR allows to read the cloud namespace from CCM config instead of always reading it from the kubeconfig.
Fixes: #78
Signed-off-by: Helene Durand helene@kubermatic.com

Signed-off-by: Helene Durand <helene@kubermatic.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 4, 2022
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2022
@kubevirt-bot
Copy link
Contributor

Hi @hdurand0710. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hdurand0710
Copy link
Contributor Author

/assign mfranczy

@mfranczy
Copy link
Contributor

mfranczy commented Jul 4, 2022

@hdurand0710 could add tests for that? Thanks.

Signed-off-by: Helene Durand <helene@kubermatic.com>
@mfranczy
Copy link
Contributor

mfranczy commented Jul 6, 2022

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@mfranczy
Copy link
Contributor

mfranczy commented Jul 6, 2022

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@mfranczy
Copy link
Contributor

mfranczy commented Jul 6, 2022

I am planning to reimplement current tests so let's say it's ok for now.
Soon we are going to have a meeting were we can discuss directions.

@kubevirt-bot kubevirt-bot merged commit 80abd6f into kubevirt:main Jul 6, 2022
@hdurand0710 hdurand0710 deleted the 78-Namespace-in-CCM-config branch September 7, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a possibility to read namespace from CCM config
3 participants