-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a possibility to read namespace from CCM config #88
Add a possibility to read namespace from CCM config #88
Conversation
Signed-off-by: Helene Durand <helene@kubermatic.com>
Hi @hdurand0710. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign mfranczy |
@hdurand0710 could add tests for that? Thanks. |
Signed-off-by: Helene Durand <helene@kubermatic.com>
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfranczy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am planning to reimplement current tests so let's say it's ok for now. |
This PR allows to read the cloud namespace from CCM config instead of always reading it from the kubeconfig.
Fixes: #78
Signed-off-by: Helene Durand helene@kubermatic.com