InstancesV2: Add option to disable getting Region and Zone labels #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: no
This change is done in order to let the user option not to get this info Currently, this info located in the Nodes, therefore it require the controller to have Node get permission (cluster scope) There is plane in kubevirt, to addopt this info also in the vmi, which will allow to get this info without the Get Node permission Related issue: kubevirt#89 Signed-off-by: Nir Argaman <nargaman@redhat.com>
nirarg
force-pushed
the
disable-region-zone
branch
from
bdf047b
to
33ec9ab
Compare
kubevirt-bot
added
dco-signoff: yes
|
/cc @mfranczy can you please review? |
|
/ok-to-test |
kubevirt-bot
added
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfranczy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is done in order to let the user option not to get this info
Currently, this info located in the Nodes, therefore it require the
controller to have Node get permission (cluster scope)
There is plane in kubevirt, to addopt this info also in the vmi,
which will allow to get this info without the Get Node permission
Related issue:
#89
Fixes issue #94