-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CNAO/KMP CONTROL_PLANE_KEY flow #1567
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
What happened:
CNAO has to remove the
KUBEMACPOOL_CONTROL_PLANE_KEY
because of two cases:It is in KMP manifest under the NS, so before applying the NS it need to remove it.
(even that it already exists, it will amend it IIRC),
See https://github.com/kubevirt/cluster-network-addons-operator/pull/1145/files#r796372158
PR manifests: Remove control-plane label from namespace k8snetworkplumbingwg/kubemacpool#389 removes it,
once there will be a KMP release we can remove the deletion during reconcile.
For backward compatibility, for versions that had this label before the fix presented by labels: Do not label operator namespace with unneeded labels #1145
We remove the labels by
cleanUpNamespaceLabels
.What you expected to happen:
Code should be cleaner and easier, while maintaining the functionality.
About 1:
We can remove it from KMP itself, and then we can remove the code mentioned on 1, see link above.
Note that we might can already remove it now due to #1566 which removes it in the KMP bump.
About 2:
Once we don't support anymore a version that had the bug pre 1145 we can remove this function.
How to reproduce it (as minimally and precisely as possible):
See notes above.
Anything else we need to know?:
Maybe we can even consider removing the NS resources in all CNAO component bump scripts.
Can be done either in the component bump scripts or maybe the reconcile should just ignore it ?
I think once we fix it, it is better to remove this code as well
https://github.com/kubevirt/cluster-network-addons-operator/pull/1566/files#diff-bec741ac25fac96fd708633e7c3fbd240ad554c225598843e75f2b0001cf2c50R131-R134
because removing all the labels instead just the offending ones, can cause problems in case
in the future there will be labels we do want to keep.
Environment:
The text was updated successfully, but these errors were encountered: