Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Remove control-plane label from namespace #389

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

oshoval
Copy link
Member

@oshoval oshoval commented Jul 16, 2023

What this PR does / why we need it:
Following https://github.com/kubevirt/cluster-network-addons-operator/pull/1145/files#r796372158
We don't need this label on KMP, and it require busy work on CNAO (see linked issue below).
Hence remove it from the namespace.

Note: the 2nd commit is manual removing from the files, where make generate didn't remove from.

Special notes for your reviewer:
See first bullet at kubevirt/cluster-network-addons-operator#1567

Release note:

None

Signed-off-by: Or Shoval <oshoval@redhat.com>
Make generate didn't remove from those files,
so removing manually.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Member Author

oshoval commented Jul 16, 2023

/cc @RamLavi

@RamLavi
Copy link
Member

RamLavi commented Jul 17, 2023

Can you run it manually to see that the label doesn't "return" unannounced by kustomize?

@oshoval
Copy link
Member Author

oshoval commented Jul 17, 2023

Can you run it manually to see that the label doesn't "return" unannounced by kustomize?

Good point,
tried, it doesn't

we should also include running make generate on the unit-test if we don't already

@RamLavi
Copy link
Member

RamLavi commented Jul 17, 2023

Can you run it manually to see that the label doesn't "return" unannounced by kustomize?

Good point, tried, it doesn't

good.
/lgtm
/approve

we should also include running make generate on the unit-test if we don't already

not sure, but it's a good idea

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 9a4f818 into k8snetworkplumbingwg:main Jul 17, 2023
3 of 4 checks passed
@oshoval
Copy link
Member Author

oshoval commented Jul 17, 2023

Thanks, once there will be a release we can update a little CNAO code (for now we can just remove the code on the 1st bullet)

no rush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants