-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifests: Remove control-plane label from namespace #389
Conversation
Signed-off-by: Or Shoval <oshoval@redhat.com>
Make generate didn't remove from those files, so removing manually. Signed-off-by: Or Shoval <oshoval@redhat.com>
/cc @RamLavi |
Can you run it manually to see that the label doesn't "return" unannounced by kustomize? |
Good point, we should also include running make generate on the unit-test if we don't already |
good.
not sure, but it's a good idea |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, once there will be a release we can update a little CNAO code (for now we can just remove the code on the 1st bullet) no rush |
What this PR does / why we need it:
Following https://github.com/kubevirt/cluster-network-addons-operator/pull/1145/files#r796372158
We don't need this label on KMP, and it require busy work on CNAO (see linked issue below).
Hence remove it from the namespace.
Note: the 2nd commit is manual removing from the files, where
make generate
didn't remove from.Special notes for your reviewer:
See first bullet at kubevirt/cluster-network-addons-operator#1567
Release note: