Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use centos:stream9 #1142

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update Dockerfile to use centos:stream9 #1142

merged 1 commit into from
Jan 19, 2022

Conversation

machadovilaca
Copy link
Member

Signed-off-by: João Vilaça jvilaca@redhat.com

What this PR does / why we need it:

CentOS 7 is scheduled for EOL as stated in https://wiki.centos.org/About/Product, and already exited the Full Updates phase.
Therefore this PR updates CentOS version in Dockerfile for new builds to use CentOS Stream 9, which is in the full support phase (https://www.centos.org/centos-stream/).

Special notes for your reviewer:

Release note:

Update Dockerfile to use CentOS Stream 9

Signed-off-by: João Vilaça <jvilaca@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@machadovilaca
Copy link
Member Author

@alonSadan @rhrazdil

There is an issue related to a bug that is causing the error seen in the tests. It causes network connection problems inside docker when accessing CentOS repositories.

I'd need to do the same as kubevirt/project-infra/pull/1829 for this repository, which updates the docker version in the image used by kubevirtci to run the tests, which will allow us to run CentOS Stream 9.

Is it ok for you if I do that?

@machadovilaca
Copy link
Member Author

Update was made in kubevirt/project-infra/pull/1616, should fix
/retest

@machadovilaca
Copy link
Member Author

/retest

@phoracek
Copy link
Member

/retest

Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 19, 2022
@kubevirt-bot kubevirt-bot merged commit c916b86 into kubevirt:main Jan 19, 2022
@machadovilaca machadovilaca deleted the use-centos-stream9-instead-of-centos-7 branch January 19, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants