Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump nmstate to v0.65.0 #1147

Merged
merged 4 commits into from Feb 1, 2022
Merged

bump nmstate to v0.65.0 #1147

merged 4 commits into from Feb 1, 2022

Conversation

github-actions[bot]
Copy link
Contributor

bump nmstate to v0.65.0
Executed by Bumper script

bump nmstate to v0.65.0

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 26, 2022
@kubevirt-bot
Copy link
Collaborator

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S labels Jan 26, 2022
@qinqon
Copy link
Collaborator

qinqon commented Jan 26, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 26, 2022
@qinqon
Copy link
Collaborator

qinqon commented Jan 27, 2022

/lgtm
/approve
/retest

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@qinqon
Copy link
Collaborator

qinqon commented Jan 31, 2022

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S labels Jan 31, 2022
@qinqon
Copy link
Collaborator

qinqon commented Jan 31, 2022

/retest

1 similar comment
@qinqon
Copy link
Collaborator

qinqon commented Jan 31, 2022

/retest

@qinqon
Copy link
Collaborator

qinqon commented Jan 31, 2022

/retest
/approve

web-flow and others added 4 commits February 1, 2022 10:42
@web-flow @qinqon
bump nmstate to v0.65.0
ecf90be 
Signed-off-by: CNAO Bump Bot <noreply@github.com>
@qinqon
go: Bump toolchain to go 1.17
33b1f91 
The nmstate projects depends on go 1.17 now.

Signed-off-by: Quique Llorente <ellorent@redhat.com>
@qinqon
go: Bump vendor with golang 1.17
ed56945 
Signed-off-by: Quique Llorente <ellorent@redhat.com>
@qinqon
automation: Install golang for nmstate
0a94213 
Signed-off-by: Quique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the bump_nmstate_to_v0.65.0_CNhdW branch from 6c321a5 to 0a94213 Compare February 1, 2022 09:45
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qinqon
Copy link
Collaborator

qinqon commented Feb 1, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit a80eeeb into main Feb 1, 2022
@RamLavi RamLavi deleted the bump_nmstate_to_v0.65.0_CNhdW branch March 23, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonSadan alonSadan Awaiting requested review from alonSadan

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @qinqon @web-flow