Bump go to k8s 1.21 #1209
Merged
Bump go to k8s 1.21 #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
rhrazdil
approved these changes
Feb 4, 2022
qinqon
force-pushed
the
bump-go-to-k8s-1.21
branch
from
75ca477
to
6517e20
Compare
There are security warnings on the project that can be fixed bumping k8s go deps. This change bump k8s, controller-runtime, controller-tools and operator-sdk. Signed-off-by: Quique Llorente <ellorent@redhat.com>
The new controller-runtime expect a context.Context on the Reconcile interface. This change add that to the controllers. Signed-off-by: Quique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
bump-go-to-k8s-1.21
branch
6 times, most recently
from
4217914
to
86c0cae
Compare
The operator-sdk 1.y.z introduced backward imcompatible changes: - The "test" package no longer exists and we have to use testenv - The operator-sdk generate does not exist and we have to sue controller-gen - The generated code is different and we have to adapt to it. Signed-off-by: Quique Llorente <ellorent@redhat.com> gen: Use controller-gen to generate k8s code Signed-off-by: Quique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
bump-go-to-k8s-1.21
branch
from
86c0cae
to
77ba47c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
rhrazdil
approved these changes
Feb 8, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-0.65 |
|
@RamLavi: #1209 failed to apply on top of branch "release-0.65": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rhrazdil
pushed a commit
to rhrazdil/cluster-network-addons-operator
that referenced
this pull request
Mar 29, 2022
* deps: Bump go to k8s 1.21 There are security warnings on the project that can be fixed bumping k8s go deps. This change bump k8s, controller-runtime, controller-tools and operator-sdk. Signed-off-by: Quique Llorente <ellorent@redhat.com> * controller: Adapt to controller-runtime version The new controller-runtime expect a context.Context on the Reconcile interface. This change add that to the controllers. Signed-off-by: Quique Llorente <ellorent@redhat.com> * deps: Adapt to v1.y.z version of operator-sdk The operator-sdk 1.y.z introduced backward imcompatible changes: - The "test" package no longer exists and we have to use testenv - The operator-sdk generate does not exist and we have to sue controller-gen - The generated code is different and we have to adapt to it. Signed-off-by: Quique Llorente <ellorent@redhat.com> gen: Use controller-gen to generate k8s code Signed-off-by: Quique Llorente <ellorent@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are security warnings on the project, they can be fixed bumping go deps to k8s 1.21.
Special notes for your reviewer:
Release note: