Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code checking #131

Merged
merged 3 commits into from Jun 5, 2019
Merged

Commits on Jun 3, 2019

  1. add vendoring for improved checking

    Signed-off-by: Petr Horacek <phoracek@redhat.com>
    phoracek committed Jun 3, 2019
    Copy the full SHA
    fb91be6 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. improve code checking

    Use goimports to check code:
    goimports checks what gofmt does plus it keeps imports in specific
    order. In this patch we:
    - replace gofmt with goimports
    - add code format checking to travis
    - reorganize Makefile a little bit
    - remove make generate-manifests from README.md since it is not needed
      during the development process
    - add Makefile target for operator-sdk build k8s
    
    Add whitespace check and auto-formatting:
    I hate trailing whitespaces. This patch adds automated check detecting
    any and Makefile target removing them.
    
    Add codegen validation:
    Add a check validating that generated code is up to date. This would
    fail on travis in case a contributor forget to run `make generate-api`.
    
    ship and goimports operator-sdk in vendor/:
    In order to make sure everyone uses the same version of operator-sdk
    producing the same code, let's keep operator-sdk in vendoring. The
    same for goimports.
    
    Signed-off-by: Petr Horacek <phoracek@redhat.com>
    phoracek committed Jun 5, 2019
    Copy the full SHA
    a6a1107 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    bc03c77 View commit details
    Browse the repository at this point in the history