[release 0.65] networkAddonsConfig status, Remove heartbeat #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
|
/hold |
kubevirt-bot
added
do-not-merge/hold
kubevirt-bot
added
release-note
|
/lgtm |
kubevirt-bot
added
lgtm
|
@RamLavi can you rebase ? |
In order to use SetStatusConditionNoHeartbeat(), bumping to v1.1.2 Signed-off-by: Ram Lavi <ralavi@redhat.com>
Removing LastHeartbeatTime from current status condition since it causes resourceVersion to rotate every networkAddonsConfig reconcile (~1 minute). Avoiding duplicate reporting using IsStatusConditionPresentAndEqual() Moving to Patch method which is better. Signed-off-by: Ram Lavi <ralavi@redhat.com>
RamLavi
force-pushed
the
release-0.65_no_heartbeat
branch
from
5b6eef7
to
309f59a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
done |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a manual backport of #1291
Special notes for your reviewer:
related PRs (needed for infra purposes): #1311, #1306
Release note: