Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmstate: Remove PDB at operator install #1465

Merged

Conversation

qinqon
Copy link
Collaborator

@qinqon qinqon commented Nov 24, 2022

What this PR does / why we need it:
When k-nmstate was deployed with CNAO and then the k-nmstate operator is installed the CNAO k-nmstate was being replaced by removing the one at the CNAO namespace but the PDB was missing on the removal, that show some alearts since the nmstate-webhook is gone. This change remove the PDB as part of the upgrade to operator process.

Special notes for your reviewer:
Closes https://bugzilla.redhat.com/show_bug.cgi?id=2139697

Release note:

nmstate: Remove PDB at operator install

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 24, 2022
@phoracek
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
When k-nmstate was deployed with CNAO and then the k-nmstate operator is
installed the CNAO k-nmstate was being replaced by removing the one at
the CNAO namespace but the PDB was missing on the removal, that show
some alearts since the nmstate-webhook is gone. This change remove the
PDB as part of the upgrade to operator process.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qinqon
Copy link
Collaborator Author

qinqon commented Nov 24, 2022

/retest

@qinqon
Copy link
Collaborator Author

qinqon commented Nov 24, 2022

/override pull-e2e-cnao-ovs-cni-functests-release-0.65

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-e2e-cnao-ovs-cni-functests-release-0.65

In response to this:

/override pull-e2e-cnao-ovs-cni-functests-release-0.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phoracek
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2022
@kubevirt-bot kubevirt-bot merged commit b0889f2 into kubevirt:release-0.65 Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants