Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multus-dynamic-networks to v0.3.2 #1725

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

kubevirt-bot
Copy link
Collaborator

bump multus-dynamic-networks to v0.3.2
Executed by Bumper script

bump multus-dynamic-networks to v0.3.2

Signed-off-by: CNAO Bump Bot <noreply@github.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 21, 2023
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@oshoval
Copy link
Collaborator

oshoval commented Nov 21, 2023

/approve

@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@oshoval
Copy link
Collaborator

oshoval commented Nov 21, 2023

Need to cherry to
release-0.89 | release-0.85

@@ -37,10 +37,10 @@ components:
metadata: v4.0.2
multus-dynamic-networks:
url: https://github.com/k8snetworkplumbingwg/multus-dynamic-networks-controller
commit: f40f85bc20f361aeeac7b4b04aa6d289c8e130f5
commit: 21b6dee0542e5f402a19b86b2b925f3bd7940bdb
branch: main
update-policy: tagged
Copy link
Collaborator

@oshoval oshoval Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maiqueb @phoracek
on release 0.89 / release 0.85 of CNAO we have multus-dynamic-networks with update-policy static
so we need to backport manually all the PRs like this one (/cherry-pick wont work because of this conflict as well)

maybe we should consider please to create branches on multus-dynamic-networks-controller ?
unless it is fine to change to tagged (but then it will take every tag, because the repo doesnt use branches)

created manually here, you can see the mentioned fields
#1726

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update it to tagged if needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1728

will create same for 0.85 once it is accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants