Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.85] Release v0.85.5 #1749

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Nov 28, 2023

What this PR does / why we need it:
Based on #1747

Remove unsupported releases until 0.69.0 (*)
0.69.0 is also flaky and not supported anymore.
This will also cause lifecycle be shorter than 4h.

(*) Do not remove the ones that RELEASES_SELECTOR choose.
There is a weird problem with RELEASES_SELECTOR,
it pointed to a version that didn't exists, and still didn't
fail (because it is used as an optional filter of the existing
releases), for now just amended it.
We can consider fixing it on a follow-up effort.

Special notes for your reviewer:

Release note:

None

Signed-off-by: GitHub <noreply@github.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 28, 2023
@oshoval oshoval marked this pull request as draft November 28, 2023 07:18
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@kubevirt-bot kubevirt-bot added size/XXL release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 28, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2023

/test pull-e2e-cnao-lifecycle-k8s-release-0.85

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2023

/test pull-e2e-cnao-lifecycle-k8s-release-0.85

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2023

it passed, basically we can delete all the releases until 0.69.0 maybe on this branch

@oshoval oshoval marked this pull request as ready for review November 28, 2023 16:14
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2023

Those seems to come and go during deployment, maybe quay is slower, or CI machines net is slower?
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1749/pull-e2e-cnao-br-marker-functests-release-0.85/1729757510232969216

/retest

Remove unsupported releases until 0.69.0 (*)
0.69.0 is also flaky.
This will also cause lifecycle be shorter than 4h.

* do not remove the ones that RELEASES_SELECTOR choose.
There is a weird problem with RELEASES_SELECTOR,
it pointed to a version that didn't exists, and still didn't
fail (because it is used as an optional filter of the existing
releases), for now just amended it.
We can consider fixing it on a follow-up effort.

Signed-off-by: Or Shoval <oshoval@redhat.com>
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2023

/retest

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2023

/retest

not sure why it doesnt manage to deploy sometimes, we need to add post mortem in case it doesnt go away

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2023

/test pull-e2e-cnao-multus-functests-release-0.85

@qinqon
Copy link
Collaborator

qinqon commented Nov 29, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@kubevirt-bot kubevirt-bot merged commit 0040616 into kubevirt:release-0.85 Nov 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants