remove over privileged rbac from cnao manifest #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
RamLavi
force-pushed
the
remove_over_previliged_rbac
branch
from
e06522a
to
010ea01
Compare
|
/retest prow hiccup |
|
/retest |
phoracek
requested changes
Jun 2, 2020
Currently the cnao rbac Policy has a segment that elevates the container privileges to all resources, and all verbs. This is too much for the cnao's needs, and also in turn changes scc to anyuid in cnv/okd clusters. Hence, the rbac segment is removed in this commit. Signed-off-by: Ram Lavi <ralavi@redhat.com>
RamLavi
force-pushed
the
remove_over_previliged_rbac
branch
from
010ea01
to
19291e6
Compare
RamLavi
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
This change prevents us from deploying anything on OpenShift. Reverting. |
phoracek
added a commit
that referenced
this pull request
Jun 4, 2020
This reverts commit 1ce8c55. We have to rework this and allow CNAO to edit more resources. By dropping of the global role, we blocked us from creating anything on OpenShift. Signed-off-by: Petr Horacek <phoracek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ram Lavi ralavi@redhat.com
What this PR does / why we need it:
Currently the cnao rbac Policy has a segment that elevates the container privileges to all resources, and all verbs.
This is too much for the cnao's needs, and also in turn changes scc to anyuid in cnv/okd clusters.
Hence, the rbac segment is removed in this commit.
Special notes for your reviewer:
Release note: