allow listing of all SCC #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold This fixes only a part of the issue |
kubevirt-bot
added
the
do-not-merge/hold
In 19291e6 we have dropped the universal ClusterRole allowing us to handle all objects. That introduced a bug where we were not able to list SCCs, despite we had a rule for it, it was limited to a single name and resulted in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1844057 Signed-off-by: Petr Horacek <phoracek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petr Horacek phoracek@redhat.com
What this PR does / why we need it:
In 19291e6 we have dropped the
universal ClusterRole allowing us to handle all objects. That introduced
a bug where we were not able to list SCCs, despite we had a rule for it,
it was limited to a single name and resulted in this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1844057
Special notes for your reviewer:
Release note: