-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate operator manifests including OLM objects #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, I really appreciate it. I have some questions, but more that requests for a change it's me trying to understand what is the scope of CSV and relation between this operator and HCO/KubeVirt.
...uster-network-addons/0.0.1/cluster-network-addons-operator.v0.0.1.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
...uster-network-addons/0.0.1/cluster-network-addons-operator.v0.0.1.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
...uster-network-addons/0.0.1/cluster-network-addons-operator.v0.0.1.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
...uster-network-addons/0.0.1/cluster-network-addons-operator.v0.0.1.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
@djzager you can leave 3rd point (to make minimal cluster role) to us, it is absolutely fine if you keep it like this (or even do |
Also, could you please update https://github.com/kubevirt/cluster-network-addons-operator#deployment with new path to manifests and requirement to create the namespace? |
I can do this, I'm going to make all of the other code changes before I update the README. Adding this to the todo.
I'll give it a couple of shots and see how it goes. Won't shut this door yet 😎 |
Looks good so far :) |
To summarize the changes in "Take version from image tag":
You should now be able to add a release process in travis to simply make the |
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks :)
@djzager could you remove the "WIP" if it's ready to be merged? |
This PR provides tooling
tools/manifest-templator
and scriptinghack/build-manifests.sh
to generate thedeploy/
directory from code.TODO:
Operator-courier integration (May need to ask for help from @slintes to get direction).Nail down the rules needed for successful operation of the cluster-network-addons-operator (can't count on being able to bind to a named cluster-role)