Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate operator manifests including OLM objects #42

Merged
merged 14 commits into from
Apr 8, 2019

Conversation

djzager
Copy link
Contributor

@djzager djzager commented Apr 4, 2019

This PR provides tooling tools/manifest-templator and scripting hack/build-manifests.sh to generate the deploy/ directory from code.

TODO:

  • Provide a method for testing this in OLM
  • Operator-courier integration (May need to ask for help from @slintes to get direction).
  • Nail down the rules needed for successful operation of the cluster-network-addons-operator (can't count on being able to bind to a named cluster-role)
  • update https://github.com/kubevirt/cluster-network-addons-operator#deployment with new path to manifests and requirement to create the namespace

@djzager djzager changed the title Generate operator manifests including OLM objects WIP: Generate operator manifests including OLM objects Apr 4, 2019
@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL labels Apr 4, 2019
@phoracek phoracek added this to the v0.3.0 milestone Apr 4, 2019
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I really appreciate it. I have some questions, but more that requests for a change it's me trying to understand what is the scope of CSV and relation between this operator and HCO/KubeVirt.

@phoracek
Copy link
Member

phoracek commented Apr 4, 2019

@djzager you can leave 3rd point (to make minimal cluster role) to us, it is absolutely fine if you keep it like this (or even do "*") in this PR. I don't want to steal too much time from you.

@phoracek
Copy link
Member

phoracek commented Apr 4, 2019

Also, could you please update https://github.com/kubevirt/cluster-network-addons-operator#deployment with new path to manifests and requirement to create the namespace?

@djzager
Copy link
Contributor Author

djzager commented Apr 4, 2019

Also, could you please update https://github.com/kubevirt/cluster-network-addons-operator#deployment with new path to manifests and requirement to create the namespace?

I can do this, I'm going to make all of the other code changes before I update the README. Adding this to the todo.

@djzager you can leave 3rd point (to make minimal cluster role) to us, it is absolutely fine if you keep it like this (or even do "*") in this PR. I don't want to steal too much time from you.

I'll give it a couple of shots and see how it goes. Won't shut this door yet 😎

@phoracek
Copy link
Member

phoracek commented Apr 4, 2019

@phoracek
Copy link
Member

phoracek commented Apr 4, 2019

Looks good so far :)

@djzager
Copy link
Contributor Author

djzager commented Apr 5, 2019

To summarize the changes in "Take version from image tag":

  • Add a new make target manifests to generate the deploy directory.
  • Remove the version pkg, I think that would surprise developers coming from other kubevirt projects
  • Make the CSV_VERSION come from the IMAGE_TAG in the makefile, defaulting to latest. When using latest we'll make the CSV_VERSION 0.0.0 which should obviously be an unreleased version.

You should now be able to add a release process in travis to simply make the IMAGE_TAG=${TRAVIS_TAG and the CSV_VERSION will be handled from that. Handling when an unreleased CSV_VERSION (in the future) replaces a released version is left to be figured out later.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2019
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow need to change the deployment command #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2019
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@phoracek
Copy link
Member

phoracek commented Apr 8, 2019

@djzager could you remove the "WIP" if it's ready to be merged?

@djzager djzager changed the title WIP: Generate operator manifests including OLM objects Generate operator manifests including OLM objects Apr 8, 2019
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2019
@phoracek phoracek merged commit d459fea into kubevirt:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants