Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move bump-all.sh functionality to Makefile #449

Merged
merged 1 commit into from
Jul 13, 2020
Merged

move bump-all.sh functionality to Makefile #449

merged 1 commit into from
Jul 13, 2020

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Jul 5, 2020 •
edited
Loading

What this PR does / why we need it:
We don't need bump-all.sh script, we can just use Makefile.

Signed-off-by: Ram Lavi ralavi@redhat.com

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 5, 2020
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jul 5, 2020

/hold
relies on #448 so will only unheld after it's merged

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2020
This was referenced Jul 6, 2020
Merged
Merged
qinqon
qinqon requested changes Jul 6, 2020
View reviewed changes
hack/components/components.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/components/components.sh Outdated Show resolved Hide resolved
@RamLavi RamLavi force-pushed the add_bump_per_component branch 4 times, most recently from 86a8e92 to bb2e543 Compare July 8, 2020 08:22
@RamLavi RamLavi mentioned this pull request Jul 8, 2020
Merged
@qinqon
Copy link
Collaborator

qinqon commented Jul 8, 2020

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
This was referenced Jul 8, 2020
Merged
Merged
@kubevirt-bot kubevirt-bot added size/M and removed lgtm Indicates that a PR is ready to be merged. size/L labels Jul 9, 2020
qinqon
qinqon requested changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass maybe we don't need bump-components.sh at all.

Makefile Outdated Show resolved Hide resolved
@RamLavi RamLavi force-pushed the add_bump_per_component branch 3 times, most recently from 5601fe3 to 310b352 Compare July 9, 2020 15:14
qinqon
qinqon reviewed Jul 9, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
hack/components/bump-knmstate.sh Outdated Show resolved Hide resolved
@RamLavi RamLavi force-pushed the add_bump_per_component branch 4 times, most recently from ac73039 to 52ac537 Compare July 9, 2020 16:01
@RamLavi RamLavi changed the title change components.sh to run only the selected comoponent move bump-all.sh functionality to Makefile Jul 12, 2020
@RamLavi RamLavi force-pushed the add_bump_per_component branch 2 times, most recently from d0a930b to 919d799 Compare July 12, 2020 11:38
@oshoval
Copy link
Collaborator

oshoval commented Jul 12, 2020

Thanks
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2020
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jul 12, 2020

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2020
@RamLavi
move bump-all.sh functionality to Makefile
d14062a 
We don't need bump-all.sh script, we can just use Makefile.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2020
phoracek
phoracek approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Closing both to eyes not to see completely unrelated TMP refactoring.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@kubevirt-bot kubevirt-bot merged commit c83232d into kubevirt:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon qinqon requested changes

@oshoval oshoval oshoval left review comments

@phoracek phoracek phoracek approved these changes

Assignees

@qinqon qinqon

@phoracek phoracek

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RamLavi @qinqon @oshoval @kubevirt-bot @phoracek