Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.53] multus, Add Priority class #909

Conversation

kubevirt-bot
Copy link
Collaborator

This is an automated cherry-pick of #898

/assign oshoval

None

As part of https://bugzilla.redhat.com/show_bug.cgi?id=1953482
We are adding Priority Class to each network component.

The motivation is to make the control plane pods less sensitive to preemption
than user workloads.

Add system-cluster-critical to multus DaemonSet.
Since multus isn't bound to a specific node,
yet its an important pod, assign system-cluster-critical
pc to it.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 23, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oshoval
Copy link
Collaborator

oshoval commented Jun 23, 2021

/cc @phoracek

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@oshoval
Copy link
Collaborator

oshoval commented Jun 23, 2021

@RamLavi can you take a look please?
By Petr request we need to backport the Priority class to 0.53

@RamLavi
Copy link
Collaborator

RamLavi commented Jun 23, 2021

/approve

@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@kubevirt-bot kubevirt-bot merged commit 3378aa4 into kubevirt:release-0.53 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants