Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to v1beta1 #44

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Move to v1beta1 #44

merged 1 commit into from
Jun 12, 2023

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jun 7, 2023 •
edited

What this PR does / why we need it:

Move to v1beta1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #41

Special notes for your reviewer:

Release note:

All generated resources have moved to the `instancetype.kubevirt.io/v1beta1` version.

@lyarwood
Move to v1beta1
bbf9487 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 7, 2023
@lyarwood
Copy link
Member Author

lyarwood commented Jun 7, 2023

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2023
@lyarwood lyarwood added this to the v0.2.0 milestone Jun 7, 2023
@lyarwood
Copy link
Member Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@lyarwood
Copy link
Member Author

/cc @0xFelix

@lyarwood lyarwood mentioned this pull request Jun 12, 2023
Merged
0xFelix
0xFelix approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@kubevirt-bot kubevirt-bot merged commit 4429d8f into kubevirt:main Jun 12, 2023
4 checks passed
@lyarwood lyarwood mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Move to v1beta1
3 participants
@lyarwood @kubevirt-bot @0xFelix