Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource labels to hyperscale instance types #49

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jun 13, 2023

What this PR does / why we need it:

The following resource labels have been added to each hyperscale
instance type to aid users searching for a type with specific resources:

  • instancetype.kubevirt.io/cpu - Number of vCPUs
  • instancetype.kubevirt.io/memory - Amount of RAM

Additionally the following optional bool labels have also been added to
relevant instance types to help users looking for more specific
resources and features:

  • instancetype.kubevirt.io/dedicatedCPUPlacement
  • instancetype.kubevirt.io/hugepages
  • instancetype.kubevirt.io/isolateEmulatorThread
  • instancetype.kubevirt.io/numa
  • instancetype.kubevirt.io/gpus

For example:

$ ./cluster-up/kubectl.sh get virtualmachineclusterinstancetype -linstancetype.kubevirt.io/hugepages=true
selecting podman as container runtime
NAME          AGE
cx1.2xlarge   113s
cx1.4xlarge   113s
cx1.8xlarge   113s
cx1.large     113s
cx1.medium    113s
cx1.xlarge    113s
m1.2xlarge    113s
m1.4xlarge    113s
m1.8xlarge    113s
m1.large      113s
m1.xlarge     113s

$ ./cluster-up/kubectl.sh get virtualmachineclusterinstancetype -linstancetype.kubevirt.io/cpu=4
selecting podman as container runtime
NAME         AGE
cx1.xlarge   3m8s
gn1.xlarge   3m8s
m1.xlarge    3m8s
n1.xlarge    3m8s

$ ./cluster-up/kubectl.sh get virtualmachineclusterinstancetype -linstancetype.kubevirt.io/cpu=4,instancetype.kubevirt.io/hugepages=true
selecting podman as container runtime
NAME         AGE
cx1.xlarge   5m47s
m1.xlarge    5m47s

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Resource labels have been introduced to each hyperscale instance type to aid users searching for instance types providing specific resources.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 13, 2023
@lyarwood lyarwood added this to the v0.2.0 milestone Jun 14, 2023
@kubevirt-bot kubevirt-bot added size/L release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XXL do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 14, 2023
@lyarwood lyarwood changed the title Scheduling hints Add resource labels to hyperscale instance types Jun 14, 2023
@lyarwood lyarwood marked this pull request as ready for review June 14, 2023 09:43
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2023
@lyarwood
Copy link
Member Author

/cc @0xFelix

The following resource labels have been added to each hyperscale
instance type to aid users searching for a type with specific resources:

* instancetype.kubevirt.io/cpu    - Number of vCPUs
* instancetype.kubevirt.io/memory - Amount of RAM

Additionally the following optional bool labels have also been added to
relevant instance types to help users looking for more specific
resources and features:

* instancetype.kubevirt.io/dedicatedCPUPlacement
* instancetype.kubevirt.io/hugepages
* instancetype.kubevirt.io/isolateEmulatorThread
* instancetype.kubevirt.io/numa
* instancetype.kubevirt.io/gpus

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@kubevirt-bot kubevirt-bot merged commit 17f59da into kubevirt:main Jun 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants