-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource labels to hyperscale instance types #49
Conversation
Skipping CI for Draft Pull Request. |
2bc74c8
to
2fa0628
Compare
/cc @0xFelix |
common-instancetypes/instancetypes/hyperscale/m/sizes/4xlarge/4xlarge.yaml
Outdated
Show resolved
Hide resolved
The following resource labels have been added to each hyperscale instance type to aid users searching for a type with specific resources: * instancetype.kubevirt.io/cpu - Number of vCPUs * instancetype.kubevirt.io/memory - Amount of RAM Additionally the following optional bool labels have also been added to relevant instance types to help users looking for more specific resources and features: * instancetype.kubevirt.io/dedicatedCPUPlacement * instancetype.kubevirt.io/hugepages * instancetype.kubevirt.io/isolateEmulatorThread * instancetype.kubevirt.io/numa * instancetype.kubevirt.io/gpus Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
2fa0628
to
dc8be11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The following resource labels have been added to each hyperscale
instance type to aid users searching for a type with specific resources:
Additionally the following optional bool labels have also been added to
relevant instance types to help users looking for more specific
resources and features:
For example:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: