Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Add common-instancetypes-version annotation during release #54

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Jun 14, 2023

What this PR does / why we need it:

Tested on my personal repo with the following release tag and action run:

https://github.com/lyarwood/common-instancetypes/releases/tag/v1.2.3

https://github.com/lyarwood/common-instancetypes/actions/runs/5280248830

This produces the following release bundle with the correct annotation:

$ curl -LJ https://github.com/lyarwood/common-instancetypes/releases/download/v1.2.3/common-clusterinstancetypes-bundle-v1.2.3.yaml | yq '.metadata.name,.metadata.annotations | with_entries(select(.key == "instancetype.kubevirt.io/common-instancetypes-version"))' common-clusterinstancetypes-bundle-v1.2.3.yaml
[..]
cx1.4xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
cx1.8xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
cx1.large
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
cx1.medium
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
cx1.xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
gn1.2xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
gn1.4xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
gn1.8xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
gn1.xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
highperformance.large
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
highperformance.medium
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
highperformance.small
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
m1.2xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
---
m1.4xlarge
---
instancetype.kubevirt.io/common-instancetypes-version: v1.2.3
[..]

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #53

Special notes for your reviewer:

Release note:

All released resources are now given a `instancetype.kubevirt.io/common-instancetypes-version` annotation denoting the release they are associated with.

@lyarwood lyarwood added this to the v0.3.0 milestone Jun 14, 2023
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 14, 2023
@lyarwood
Copy link
Member Author

This needs to run against the generated files, not only the files we import into SSP.

@lyarwood lyarwood modified the milestones: v0.3.0, v0.2.1 Jun 14, 2023
@lyarwood lyarwood force-pushed the github-common-instancetypes-version-annotation branch from 2136622 to 7c8fdca Compare June 15, 2023 14:23
@lyarwood lyarwood force-pushed the github-common-instancetypes-version-annotation branch 2 times, most recently from f0ed8c7 to 3ff4644 Compare June 15, 2023 14:40
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the github-common-instancetypes-version-annotation branch 2 times, most recently from d149519 to a17d006 Compare June 15, 2023 14:58
@kubevirt-bot kubevirt-bot added size/XS release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/M do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 15, 2023
@lyarwood lyarwood marked this pull request as ready for review June 15, 2023 15:00
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2023
@ksimon1
Copy link
Member

ksimon1 commented Jun 16, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@kubevirt-bot kubevirt-bot merged commit 4941f45 into kubevirt:main Jun 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instancetype.kubevirt.io/common-instancetype-version annotation to each generated resource
4 participants