New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Add common-instancetypes-version annotation during release #54
github: Add common-instancetypes-version annotation during release #54
Conversation
Skipping CI for Draft Pull Request. |
This needs to run against the generated files, not only the files we import into SSP. |
2136622
to
7c8fdca
Compare
f0ed8c7
to
3ff4644
Compare
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
d149519
to
a17d006
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Tested on my personal repo with the following release tag and action run:
https://github.com/lyarwood/common-instancetypes/releases/tag/v1.2.3
https://github.com/lyarwood/common-instancetypes/actions/runs/5280248830
This produces the following release bundle with the correct annotation:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #53
Special notes for your reviewer:
Release note: