New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Fix bundle version labelling #64
github: Fix bundle version labelling #64
Conversation
715b2c7
to
6eb3d76
Compare
* Replace the annotation with a label * Avoid merging bundles togther when using yq * Remove unnecessary exports of env variables Note that VERSION remains exported for yq Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
6eb3d76
to
a90ed4f
Compare
Tested below and now working correctly: https://github.com/lyarwood/common-instancetypes/releases/tag/v1.2.7
|
@@ -16,10 +16,12 @@ jobs: | |||
for f in $(ls *bundle.yaml); do | |||
cp ${f} ${f/\.yaml/-${VERSION}\.yaml} | |||
done | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this is just pre-commit
cleaning up whitespace that shellcheck
somehow missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.3 |
@lyarwood: new pull request created: #85 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: