Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide VM templates from the developer catalog #143

Merged
merged 1 commit into from Apr 15, 2020

Conversation

akrejcir
Copy link
Contributor

@akrejcir akrejcir commented Apr 3, 2020

To instantiate a VM template, the user would have
to provide the name of PVC with the VM's disk.
Without it the template would not work.

This patch hides the VM templates from the catalog,
so users will not be confused.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Apr 3, 2020
@akrejcir
Copy link
Contributor Author

akrejcir commented Apr 3, 2020

/retest

2 similar comments
@ksimon1
Copy link
Member

ksimon1 commented Apr 3, 2020

/retest

@akrejcir
Copy link
Contributor Author

/retest

To instantiate a VM template, the user would have
to provide the name of PVC with the VM's disk.
Without it the template would not work.

This patch hides the VM templates from the catalog,
so users will not be confused.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@ksimon1 ksimon1 merged commit 0b07dcc into kubevirt:master Apr 15, 2020
@akrejcir akrejcir deleted the hide-templates-in-catalog branch April 15, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants