Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new SRCPVCNAME and SRCPVCNAMESPACE params #168

Merged
merged 1 commit into from
Sep 1, 2020
Merged

add new SRCPVCNAME and SRCPVCNAMESPACE params #168

merged 1 commit into from
Sep 1, 2020

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Aug 17, 2020 •
edited

add new SRC_PVC_NAME and SRC_PVC_NAMESPACE params to all templates.

These new params are added to unblock UI. They are not used in common templates
yet. In the future they will be used for datavolume template.

add new SRC_PVC_NAME and SRC_PVC_NAMESPACE params to all templates.

Signed-off-by: Karel Simon ksimon@redhat.com

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 17, 2020
fabiand
fabiand reviewed Aug 17, 2020
View reviewed changes
templates/_linux.yaml

- name: SRCPVCNAME
description: Name of the PVC to clone
value: '{{ oslabels | last }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What values would occur here? Can you give a few examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.

rhel8.2
rhel7.9
centos8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these valid PVC names?
I suspect that anyething with a dot is not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksimon1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names with dot are valid k8s names

omeryahud
omeryahud suggested changes Aug 18, 2020
View reviewed changes
templates/_linux.yaml Outdated Show resolved Hide resolved
omeryahud
omeryahud reviewed Aug 23, 2020
View reviewed changes
templates/_linux.yaml Outdated
value: '{{ oslabels | last }}'
- name: SRC_PVC_NAMESPACE
description: Namespace of the source PVC
value: openshift-kubevirt-base-images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use kubevirt-base-images, and then patch it to openshift-cnv-base-images downstream, what do you think?
@ksimon1 @fabiand @shwetaap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ksimon1
add new SRCPVCNAME and SRCPVCNAMESPACE params to all templates
2750cfb 
These new params are added to unblock UI. They are not used in common templates
yet. In the future they will be used for datavolume template.

Signed-off-by: Karel Simon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 25, 2020
@yaacov yaacov mentioned this pull request Aug 25, 2020
Merged
omeryahud
omeryahud approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@omeryahud omeryahud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@omeryahud
Copy link
Contributor

/retest

@omeryahud
Copy link
Contributor

/cc @shwetaap
Could you take a look at this Shweta? It would also help you figure out how you should update the default namespace downstream

@shwetaap
Copy link
Contributor

/cc @shwetaap
Could you take a look at this Shweta? It would also help you figure out how you should update the default namespace downstream
I see that the default namespace has been set to kubevirt-base-images as discussed. But where do we modify this to use the openshift namespace in downstream?

@ksimon1
Copy link
Member Author

ksimon1 commented Aug 27, 2020

I see that the default namespace has been set to kubevirt-base-images as discussed. But where do we modify this to use the openshift namespace in downstream?

This will be updated in d/s automation pipeline

@shwetaap
Copy link
Contributor

I see that the default namespace has been set to kubevirt-base-images as discussed. But where do we modify this to use the openshift namespace in downstream?

This will be updated in d/s automation pipeline

ok got it. Thanks!

@shwetaap
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@ksimon1 ksimon1 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@omeryahud
Copy link
Contributor

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omeryahud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@kubevirt-bot kubevirt-bot merged commit 2c3f9d8 into kubevirt:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiand fabiand fabiand left review comments

@omeryahud omeryahud omeryahud approved these changes

@rnetser rnetser Awaiting requested review from rnetser

@shwetaap shwetaap Awaiting requested review from shwetaap

Assignees

@shwetaap shwetaap

@omeryahud omeryahud

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ksimon1 @omeryahud @shwetaap @kubevirt-bot @fabiand