Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop major verison from PVC names of community OSs #284

Merged
merged 1 commit into from Nov 22, 2020

Conversation

omeryahud
Copy link
Contributor

Signed-off-by: Omer Yahud oyahud@redhat.com

What this PR does / why we need it:
Drop major verison from PVC names of community OSs in order to have a fixed PVC for upgrades and prevent confusion with a constantly updated description

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1897081

Special notes for your reviewer:

Release note:

NONE

… fixed PVC for upgrades and prevent confusion with a constantly updated description

Signed-off-by: Omer Yahud <oyahud@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 12, 2020
@omeryahud
Copy link
Contributor Author

/retest

1 similar comment
@omeryahud
Copy link
Contributor Author

/retest

@akrejcir
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@omeryahud
Copy link
Contributor Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omeryahud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2020
@kubevirt-bot kubevirt-bot merged commit 7ec248d into kubevirt:master Nov 22, 2020
@omeryahud
Copy link
Contributor Author

/cherry-pick release-0.12

@kubevirt-bot
Copy link
Contributor

@omeryahud: cannot checkout release-0.12: error checking out release-0.12: exit status 1. output: error: pathspec 'release-0.12' did not match any file(s) known to git.

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omeryahud
Copy link
Contributor Author

/cherry-pick release-v0.12

@kubevirt-bot
Copy link
Contributor

@omeryahud: new pull request created: #289

In response to this:

/cherry-pick release-v0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants