Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 2022 template is missing vTPM and UEFI #486

Merged
merged 1 commit into from Oct 25, 2022
Merged

Windows 2022 template is missing vTPM and UEFI #486

merged 1 commit into from Oct 25, 2022

Conversation

Barakmor1
Copy link
Member

@Barakmor1 Barakmor1 commented Oct 20, 2022 •
edited

Signed-off-by: bmordeha bmodeha@redhat.com

What this PR does / why we need it:
Windows 2022 template is missing vTPM and UEFI
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

add vTPM and UEFI to Windows 2022 template

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 20, 2022
@kubevirt-bot kubevirt-bot added size/XS release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 20, 2022
@Barakmor1
Copy link
Member Author

/test e2e-azure-common-templates-windows2022

@kubevirt-bot
Copy link
Contributor

@Barakmor1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-azure-common-templates-windows2022

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Barakmor1
Copy link
Member Author

Barakmor1 commented Oct 24, 2022 •
edited

@ksimon1
Hey,
I need to update windows2022 image to include UEFI to make it work,
but the old manifest doesn't work with the new image so i think that we should
switch the images AND the manifest as fast as possible.
Maybe it would be better if we will approve this PR before i'll update the image so
this PR will land faster.
What do you think?
/test e2e-azure-common-templates-rhel6
/test e2e-azure-common-templates-windows2019

@kubevirt-bot
Copy link
Contributor

@Barakmor1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

@ksimon1
Hey,
I need to update windows2022 image to include UEFI to make it work,
but the old manifest doesn't work with the new image so i think that we should
switch the images as fast as possible.
Maybe it would be better if we will approve this PR before i'll update the images so
this PR will get merged faster.
/test e2e-azure-common-templates-rhel6
/test e2e-azure-common-templates-windows2019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Barakmor1
Copy link
Member Author

/test e2e-azure-common-templates-windows2022

@kubevirt-bot
Copy link
Contributor

@Barakmor1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-azure-common-templates-windows2022

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dominikholler
Copy link
Collaborator

@Barakmor1 From my point of view it would be helpful, of the commit message would explain the "missing". In which way Win2k22 guests would benefit from using uefi and vTPM, and what would be the drawbacks relative to use BIOS?

Windows 2022 template is missing TPM and UEFI
e267e74 
Uefi will allow security features like Secure Boot,
Faster boot and resume times,
Support for UEFI firmware drivers, applications,
and option ROMs.

TPM will allow Generate, store, and limit the use
of cryptographic keys.
Help ensure platform integrity by taking
and storing security measurements.

Signed-off-by: bmordeha <bmodeha@redhat.com>
@Barakmor1
Copy link
Member Author

@Barakmor1 From my point of view it would be helpful, of the commit message would explain the "missing". In which way Win2k22 guests would benefit from using uefi and vTPM, and what would be the drawbacks relative to use BIOS?

Thanks for the comment.
I updated the commit massage.

@dominikholler
Copy link
Collaborator

@Barakmor1 From my point of view it would be helpful, of the commit message would explain the "missing". In which way Win2k22 guests would benefit from using uefi and vTPM, and what would be the drawbacks relative to use BIOS?

Thanks for the comment. I updated the commit massage.

Thanks for improving the commit message!

@ksimon1
Copy link
Member

ksimon1 commented Oct 25, 2022

/retest

@ksimon1
Copy link
Member

ksimon1 commented Oct 25, 2022

/lgtm
/approve
/cherrypick release-v0.24

@kubevirt-bot
Copy link
Contributor

@ksimon1: once the present PR merges, I will cherry-pick it on top of release-v0.24 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherrypick release-v0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@kubevirt-bot kubevirt-bot merged commit f7d51f6 into kubevirt:master Oct 25, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Oct 25, 2022
Merged
@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #488

In response to this:

/lgtm
/approve
/cherrypick release-v0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@geetikakay geetikakay Awaiting requested review from geetikakay

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Barakmor1 @kubevirt-bot @dominikholler @ksimon1