Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig-observability charter #282

Merged
merged 1 commit into from Apr 10, 2024

Conversation

machadovilaca
Copy link
Member

What this PR does / why we need it:

Add sig-observability charter

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 3, 2024
@machadovilaca
Copy link
Member Author

@avlitman
Copy link

avlitman commented Apr 3, 2024

This is great! small nit: maybe add a link to the best practices

@machadovilaca
Copy link
Member Author

This is great! small nit: maybe add a link to the best practices

@avlitman in the template mentions we are not supposed list of specific code locations, the idea is just give a responsibility overview I think
https://github.com/kubevirt/community/blob/main/sig-TEMPLATE/sig-charter-template.md

@avlitman
Copy link

avlitman commented Apr 3, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@sradco
Copy link

sradco commented Apr 4, 2024

/lgtm

@fabiand
Copy link
Member

fabiand commented Apr 10, 2024

/approve

Thanks!

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabiand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@kubevirt-bot kubevirt-bot merged commit 365c0cd into kubevirt:main Apr 10, 2024
2 checks passed
@fabiand
Copy link
Member

fabiand commented Apr 10, 2024

Darn

@machadovilaca please also open a PR with an update to sigs.yaml in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants