Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDI files not automatically converted to raw #1287

Closed
mazzystr opened this issue Jul 6, 2020 · 9 comments
Closed

VDI files not automatically converted to raw #1287

mazzystr opened this issue Jul 6, 2020 · 9 comments
Labels
kind/bug lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mazzystr
Copy link

mazzystr commented Jul 6, 2020

/kind bug

What happened:
Executed virtctl image-upload against a VirtualBox VDI disk image
Created VM
Started VM
VM failed to boot saying no bootable

qemu supports vdi natively per doc and manual process check ... so what gives??

What you expected to happen:
VM boots as expected

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
This is pretty silly when CDI has conversion code
https://github.com/kubevirt/containerized-data-importer/blob/master/pkg/importer/data-processor.go#L190
https://github.com/kubevirt/containerized-data-importer/blob/master/pkg/image/qemu.go#L101

There are many many disk img types. Either we support them natively as qemu does, provide a switch to convert them to raw, or be very explicit about it in docs.

Environment:

  • CDI version (use kubectl get deployments cdi-deployment -o yaml):
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install tools:
  • Others:
@awels
Copy link
Member

awels commented Jul 7, 2020

@mazzystr
Copy link
Author

mazzystr commented Jul 8, 2020

@awels definitely not

@awels
Copy link
Member

awels commented Jul 9, 2020

For a variety of reasons we only support RAW and qcow2 conversions with optional xz and gz compression. I am trying to understand what is not sufficient so we can address the issue.

@mazzystr
Copy link
Author

mazzystr commented Jul 9, 2020

I'm good with qemu running qcow2 or raw virtual disks.

This issues is regarding migration of a source virtual disk which could be something else like VMware vmdk or Oracle/VirtualBox vdi. Right now users are having to manually run qemu-img or get a surprise no boot disk found error. I could have swore 2 or 3 weeks ago my vdi auto converted. That's definitely not happening now. That is a big loss in functionality whereas oVirt/RHEV and OpenStack world have seamless migration tools.

Funkier yet it appears there is some auto qemu-img code but it isn't being activated correctly.

There's also a conversation happening in kubevirt-devel mailing list

@awels
Copy link
Member

awels commented Jul 9, 2020

At no point have we supported anything but qcow2 or raw images. if it worked something probably converted it to one of the two formats before you uploaded. I am monitoring that email thread.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 7, 2020
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 6, 2020
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants