Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.34] [Bugfix] wrong interpretation of custom cert rotation params #1792

Merged
merged 1 commit into from May 19, 2021
Merged

[release-v1.34] [Bugfix] wrong interpretation of custom cert rotation params #1792

merged 1 commit into from May 19, 2021
+76 −94

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #1775

/assign awels

Bugfix:  Interpret custom cert rotation params correctly

@mhenriks
fix custom cert rotation params
a2cfd8b 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request May 18, 2021
Merged
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 18, 2021
@awels
Copy link
Member

awels commented May 18, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@mhenriks
Copy link
Member

/retest

2 similar comments
@awels
Copy link
Member

awels commented May 18, 2021

/retest

@maya-r
Copy link
Contributor

maya-r commented May 19, 2021

/retest

@awels
Copy link
Member

awels commented May 19, 2021

retesting won't help until #1794 is merged.

@awels
Copy link
Member

awels commented May 19, 2021

/override pull-containerized-data-importer-e2e-k8s-1.17-ceph
/override pull-containerized-data-importer-e2e-k8s-1.17-hpp

@kubevirt-bot
Copy link
Contributor Author

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.17-ceph, pull-containerized-data-importer-e2e-k8s-1.17-hpp

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.17-ceph
/override pull-containerized-data-importer-e2e-k8s-1.17-hpp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 35ee303 into kubevirt:release-v1.34 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke Awaiting requested review from aglitke

@awels awels Awaiting requested review from awels

Assignees

@awels awels

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubevirt-bot @awels @mhenriks @maya-r