-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less dependencies for containerized-data-importer-api #2032
Conversation
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
Signed-off-by: Roman Mohr <rmohr@redhat.com>
@nirarg could you check if that is sufficient or do we have to get rid of kubevirt.io/controller-lifecycle-operator-sdk right now already? |
/retest |
/cc @mhenriks should be ready for review. |
/lgtm |
Thanks @rmohr! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-containerized-data-importer-e2e-k8s-1.22-hpp-istio |
What this PR does / why we need it:
Generate golang openapi spec files in
pkg/apis
instead ofstaging/src/kubevirt.io/containerized-data-importer-api/
. This allows reducing some dependencies for third parties using our api repos.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: